Messages in this thread | | | Date | Fri, 2 May 2003 07:56:17 +0200 | From | Willy Tarreau <> | Subject | Re: Aic7xxx and Aic79xx Driver Updates |
| |
On Thu, May 01, 2003 at 10:25:31PM -0600, Justin T. Gibbs wrote:
> Can you try with this patch? It seems I forgot to pull part of a change > from the aic79xx driver into the aic7xxx driver. This could easily cause > a lock order reversal. <sigh>
Congratulations, Justin, you just spotted it !
I cannot hang it anymore. It supported an fsck and the make -j dep. I'm happy, I'll be able to reintegrate your updates to my tree ! I just have changed one typo for it to compile :
> --- /tmp/tmp.29873.2 2003-05-01 22:21:54.000000000 -0600 > +++ /home/gibbs/bk/linux-2.4/drivers/scsi/aic7xxx/aic7xxx_osm.h 2003-05-01 22:21:10.000000000 -0600 > @@ -745,7 +746,8 @@ > ahc_midlayer_entrypoint_unlock(struct ahc_softc *ahc, unsigned long *flags) > { > #if AHC_SCSI_HAS_HOST_LOCK == 0 > - ahc_unlock(ahc, flags); > + spin_unlock(&ahd->platform_data->spin_lock);
^^^^ this one is in fact &ahc->platform_data...
Thanks ;-) Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |