Messages in this thread | | | Subject | Re: [PATCH][ATM] add reference counting to atm_dev | Date | Wed, 14 May 2003 18:21:27 -0400 | From | chas williams <> |
| |
In message <20030514205949.GA3945@kroah.com>,Greg KH writes: >Any reason to not just use a struct device here? This is a device, >right? Or at the very least, a kobject would be acceptable.
actually, i think it should possibly be a netdevice. eventually i will consider this path.
>Please don't roll your own reference counting code, when we've already >gotten a in-kernel version that has been debugged quite well.
netdevice has this which is why i would probably use that. i would also get kobject support for free there (or so i imagine)
>Is this going to help us be able to get rid of the MOD_* calls in ATM >drivers soon?
no. a later patch will get rid of those though. next in the queue will be to make atm itself modular and make vcc's do reference counting (via their struct sock parent). i could fix the MOD_ nonsense next if its really bothering you.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |