Messages in this thread | | | Date | Wed, 14 May 2003 22:29:38 +0200 | From | Patrick McHardy <> | Subject | Re: [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state |
| |
David S. Miller wrote:
>You didn't test this change. x->type is a pointer, not a place where >you put XFRM_STATE_DEAD, a simple compile test would have alerted >this to you. > >
Sorry about that, i recreated the fix in a different tree and broke it.
>This also means you couldn't possibly have tested if this even >makes the assertion go away, it couldn't possibly have fixed this.. > >The correct fix, of course, is to set x->km.state to this value. >This is what I've done in my tree. > >Please be a LOT more careful with your changes. >
Promised.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |