Messages in this thread Patch in this message | | | Date | Tue, 13 May 2003 03:14:12 -0400 | From | Ben Collins <> | Subject | Re: [PATCH] Make KOBJ_NAME_LEN match BUS_ID_SIZE |
| |
On Tue, May 13, 2003 at 08:10:32AM +0100, Christoph Hellwig wrote: > On Tue, May 13, 2003 at 02:26:40AM -0400, Ben Collins wrote: > > This was causing me all sorts of problems with linux1394's 16-18 byte > > long bus_id lengths. The sysfs names were all broken. > > > > This not only makes KOBJ_NAME_LEN match BUS_ID_SIZE, but fixes the > > strncpy's in drivers/base/ so that it can't happen again (atleast the > > strings will be null terminated). > > What about defining BUS_ID_SIZE in terms of KOBJ_NAME_LEN?
Ok, then add this in addition to the previous patch.
Index: include/linux/device.h =================================================================== RCS file: /home/scm/linux-2.5/include/linux/device.h,v retrieving revision 1.48 diff -u -u -r1.48 device.h --- include/linux/device.h 29 Apr 2003 17:30:20 -0000 1.48 +++ include/linux/device.h 13 May 2003 07:47:39 -0000 @@ -35,7 +35,7 @@ #define DEVICE_NAME_SIZE 50 #define DEVICE_NAME_HALF __stringify(20) /* Less than half to accommodate slop */ #define DEVICE_ID_SIZE 32 -#define BUS_ID_SIZE 20 +#define BUS_ID_SIZE KOBJ_NAME_LEN enum { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |