Messages in this thread | | | Date | Tue, 13 May 2003 23:40:50 +0100 | From | Russell King <> | Subject | Re: [patch] 2.4 fix to allow vmalloc at interrupt time |
| |
On Tue, May 13, 2003 at 02:17:07PM -0700, William Lee Irwin III wrote: > On Tue, May 13, 2003 at 02:11:12PM -0700, Matthew Jacob wrote: > > This fixes a buglet wrt doing vmalloc at interrupt time for 2.4. > > get_vm_area should call kmalloc with GFP_ATOMIC- after all, it's > > set up to allow for an allocation failure. As best as I read > > the 2.4 code, the rest of the path through _kmem_cache_alloc > > should be safe. > > Try write_lock_irq(&vmlist_lock)/read_lock_irq(&vmlist_lock) and > passing in a gfp mask with an alternative API etc. for the interrupt > time special case. It's deadlockable without at least the locking bits. > > But it's worse than that, the implicit smp_call_function() means this > is stillborn and infeasible period.
Not to mention the page table allocation code...
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |