Messages in this thread | | | Date | Mon, 12 May 2003 09:19:48 -0700 | From | David Brownell <> | Subject | Re: [linux-usb-devel] Patch for usb-ohci in 2.4 needs review & testing |
| |
Hi Pete,
> The attached patch appears to fix a bug which was really making > my life difficult: dd if=/dev/scd0 produces corrupted ISOs when > reading off a USB CD-ROM on a box with no less than 2 P4 CPUs, > HyperThreading and ServerWorks chipset. However, I'm not > completely sure that I didn't break something.
Did the "ohci-hcd" backport give the same problem? Or did you not try that?
That 2.5 code has had a lot more attention paid to it with respect to locking and similar less-common problems. Personally I'd rather see that version get the attention, so both 2.4 and 2.5 get the benefits, although I can also understand wanting changes that seem more incremental.
> - The whole idea of checking jiffy-sized timeouts from an interrupt > is revolting, but I am wary of unknown here, so I didn't kill it. > If anyone knows how that abomination came to life, I'll be glad > to know too.
It shouldn't actually be alive ... never enabled, because never debugged (and submitted by accident). Safe IMO to remove completely.
In fact the last time the issue of HCD-enforced timeouts came up, nobody had anything positive to say about it. No portable driver has ever been able to rely on it. What's been lacking is the will to rip all such code out; in 2.5 only "uhci-hcd" has any such code left.
- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |