Messages in this thread | | | Subject | Re: [ATM] [UPDATE] unbalanced exit path in Forerunner HE he_init_one() (and an iphase patch too!) | Date | Sat, 10 May 2003 09:52:49 -0400 | From | chas williams <> |
| |
In message <20030510062015.A21408@infradead.org>,Christoph Hellwig writes: >> +init_one_failure: >> + if (atm_dev) atm_dev_deregister(atm_dev); >> + if (he_dev) kfree(he_dev); >> + pci_disable_device(pci_dev); >> + return err; > >kfree(NULL) if perfectly fine. Also please untangle all this if >statements to two separate lines.
but its ok for usb drivers?
class/usb-midi.c: if ( u ) kfree(u); class/usblp.c: if (usblp->statusbuf) kfree(usblp->statusbuf); class/usblp.c: if (usblp->device_id_string) kfree(usblp->device_id_string); image/mdc800.c:#define try_free_mem(A) if (A != 0) { kfree (A); A=0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |