lkml.org 
[lkml]   [2003]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: qla1280 mem-mapped I/O fix
From
Date
On Sat, 2003-05-10 at 02:51, David Mosberger wrote:
> With the fix in the second hunk, I don't see any reason not to turn on
> MEMORY_MAPPED_IO in qla1280. It seems to work fine on my machine
> with this controller (ia64 Big Sur).

David, you absolute MAY NOT pass this:

> - pci_read_config_word (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
> + pci_read_config_dword (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);

into ioremap() which is exactly what this driver is doing.
One must use the PCI device struct resource values.

--
David S. Miller <davem@redhat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.454 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site