Messages in this thread | | | From | Steven Whitehouse <> | Subject | Re: Remains of seq_file conversion for DECnet, plus fixes | Date | Thu, 1 May 2003 22:35:46 +0100 (BST) |
| |
Hi,
> > On Thu, May 01, 2003 at 09:52:01PM +0100, Steven Whitehouse wrote: > > --- linux-2.5.68-bk10/fs/seq_file.c Sun Apr 20 03:27:58 2003 > > +++ linux/fs/seq_file.c Mon Apr 21 14:40:35 2003 > > @@ -338,3 +338,13 @@ > > kfree(op); > > return res; > > } > > + > > +int kfree_release(struct inode *inode, struct file *file) > > +{ > > + struct seq_file *seq = file->private_data; > > + > > + kfree(seq->private); > > + seq->private = NULL; > > + return seq_release(inode, file); > > +} > > The name is a bit generic for an export function. What about > seq_release_kfree? >
Yes, I'd considered that and eventually settled for the non-prefixed version since it followed the pattern set by single_release() which doesn't have the seq_ prefix. I don't mind changing it though if the prefixed version is preferred,
Steve.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |