Messages in this thread | | | Date | Wed, 9 Apr 2003 00:41:24 -0700 | From | Greg KH <> | Subject | Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs |
| |
On Wed, Apr 09, 2003 at 08:18:21AM +0200, Martin Schlemmer wrote: > On Wed, 2003-04-09 at 00:04, Greg KH wrote: > > > Oh, I'm getting the following warning when building the driver, want to > > look into this? > > > > drivers/i2c/chips/w83781d.c: In function `store_fan_div_reg': > > drivers/i2c/chips/w83781d.c:715: warning: `old3' might be used uninitialized in this function > > > > It is because old3 is only referenced if: > > ((data->type != w83781d) && data->type != as99127f) > > as those two chips don't have extended divisor bits ... > > It is however set in the first occurrence: > > --------------------------------------------------------------------- > /* w83781d and as99127f don't have extended divisor bits */ > if ((data->type != w83781d) && data->type != as99127f) { > old3 = w83781d_read_value(client, W83781D_REG_VBAT); > } > --------------------------------------------------------------------- > > and thus is rather gcc being brain dead for not being able to figure > old3 is only used within a if block like that. > > I was not sure about style policy in a case like this, so I left it as > is, it should however be possible to 'fix' it with:
Thanks, I've applied this.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |