Messages in this thread | | | Date | Wed, 9 Apr 2003 16:31:24 -0700 | From | Greg KH <> | Subject | Re: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware |
| |
On Wed, Apr 09, 2003 at 10:28:25AM +0200, Duncan Sands wrote: > > > Hi Greg, I'm waiting on the fixes to the ATM layer (coming soon to a > > > kernel near you). > > > > Ah, ok, that makes sense. > > > > > As for the position of MOD_INC_USE_COUNT, did you ever hear > > > of anyone getting bitten by a race like this? If it makes you feel > > > better, I will move it up, probably just before I take the semaphore > > > (since that is the first place we can sleep). I will do it tomorrow, OK? > > > > Yes, it needs to be before any function that can sleep. I'll hold off > > applying this patch then. > > How about this one instead. MOD_INC_USE_COUNT is placed before I call > any functions that can sleep. Let's just hope that the call to me doesn't > come after some sleeping in the higher layers...
Much better, thanks. Applied.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |