Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] take 48-bit lba a bit further | From | Alan Cox <> | Date | 06 Apr 2003 17:27:31 +0100 |
| |
On Sul, 2003-04-06 at 17:43, Petr Vandrovec wrote: > > Works perfectly in testing here, ext2/3 generates nice big 512KiB > > requests and the drive flies. > > > > (void) probe_lba_addressing(drive, 1); > > > > + if (drive->addressing) > > + blk_queue_max_sectors(&drive->queue, 1024); > > + > > Should not you honor host's max queue length? siimage & pdc4030 sets > max_sectors to 128 (resp. 16 resp. 127), while you overwrite it here > unconditionally with 1024.
For production code thats required. The actual change required is to clamp the default/hwif set queue limit to 256 if driver->addressing !=1
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |