Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 4 Apr 2003 13:18:12 +0100 | From | Dave Jones <> | Subject | Re: [patch] acpi compile fix |
| |
On Thu, Apr 03, 2003 at 01:05:05PM -0800, Andrew Morton wrote:
> diff -puN drivers/acpi/osl.c~acpi-spinlock-casts drivers/acpi/osl.c > --- 25/drivers/acpi/osl.c~acpi-spinlock-casts Thu Apr 3 13:00:54 2003 > +++ 25-akpm/drivers/acpi/osl.c Thu Apr 3 13:01:25 2003 > @@ -736,7 +736,7 @@ acpi_os_acquire_lock ( > if (flags & ACPI_NOT_ISR) > ACPI_DISABLE_IRQS(); > > - spin_lock(handle); > + spin_lock((spinlock_t *)handle);
Is there a reason these functions can't just have their arguments changed to take a spinlock_t* instead of an acpi_handle ? That cast looks really fugly IMO.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |