Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 29 Apr 2003 01:28:36 +0530 | From | Dipankar Sarma <> | Subject | Re: [PATCH] reducing overheads in fget/fput |
| |
On Mon, Apr 28, 2003 at 08:32:28PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote: > You are. Have a process share file table at the time of call and > have its sibling die in the middle. Oops - condition that had > been true at time of fget_light() (->files->count > 1) is false > at the time we fput_light(). Have fun - we had just leaked a > reference to struct file.
That shouldn't be very difficult to fix. For the fget_light/fput_light pair in a syscall, we make the files->count == 1 check only once at the beginning. Do you see a problem with that ?
Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |