Messages in this thread | | | Subject | Re: [PATCH] aha1740 update | From | Marc Zyngier <> | Date | 24 Apr 2003 15:34:25 +0200 |
| |
>>>>> "CH" == Christoph Hellwig <hch@infradead.org> writes:
>> +/* This should really fit in driver/scsi/scsi.h, along with >> + * scsi_to_{pci,sbus}_dma_dir.... */
CH> Right. Please submit a patch to James.
I think this would cause some troubles. I would have to include linux/dma-mapping in driver/scsi/scsi.h, but many non-PCI architectures are still including asm-generic/dma-mapping.h, which has lots of references to PCI functions... I'm afraid this would clash badly on, say, sparc or m68k...
CH> Well, and as you're touching the driver big time a cleanup to follow CH> Documentation/CondingStyle would be nice.
I totally agree with the rest of your comments, and will submit an updated patch shortly.
Thanks,
M. -- Places change, faces change. Life is so very strange. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |