Messages in this thread | | | Date | Wed, 23 Apr 2003 12:02:44 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Undefined symbol sync_dquots_dev() in quota.c |
| |
On Wed, Apr 23, 2003 at 11:59:16AM -0400, Stephane Ouellette wrote: > Jeff Garzik wrote: > > >On Wed, Apr 23, 2003 at 11:28:58AM -0400, Stephane Ouellette wrote: > > > > > >>Folks, > >> > >> the following patch fixes a compile error under 2.4.21-rc1-ac1. > >>sync_dev_dquots() is undefined if CONFIG_QUOTA is not set. > >> > >> > > > >The right fix would be to make sure a no-op version of sync_dev_dquots > >exists for that case. > > > > Jeff > > > > > > Jeff, > > the file fs/dquot.c is compiled only if CONFIG_QUOTA is set. That > would imply modifying the Makefile and #ifdeffing most of the code > inside dquot.c.
So? ;-)
Your patch modified fs/quota.c, which is compiled when CONFIG_QUOTACTL is set, which in turn is set for CONFIG_QUOTA || CONFIG_XFS_QUOTA.
If you are adding CONFIG_QUOTA ifdefs to fs/quota.c, it is clear a non-ifdef solution can be achieved.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |