Messages in this thread | | | From | Eric Northup <> | Subject | Re: 2.5.68 IDE Oops at boot [working now] | Date | Tue, 22 Apr 2003 16:37:30 -0400 |
| |
On Sunday 20 April 2003 02:35 pm, Manfred Spraul wrote: > Eric Northup wrote: > >init_irq called for hwif ide0. > >hdc: MAXTOR 6L080L4, ATA DISK drive > > init_irq called, but does nothing. > > >init_irq called for hwif ide2. > >blk_init_queue: c04c99d4 initialized. > > This is what's supposed to happen: init_irq initialized the queues. > > Two bugs: > - why doesn't init_irq initialize the queues for the siimage controller? > I found a difference between 2.5.67 and 68: init_irq always returns 0, > even on error. It should return 1 on error. (It wasn't difficult to > find, I introduced it :-( > - The error handling is bad. Probably drive->present should be forced to > 0, if the queues could not be initialized. > > Could you try the attached patch? It fixes the return code and adds some > additional printks. > > -- > Manfred
This fixes it, thank you very much! I am currently running 2.5.68 with your IDE patch. One annoyance is that the order of IDE channels is different between 2.4.20 and 2.5.68 - the Silicon Image SATA controller is detected first on 2.5 but not on 2.4. I've just put a simple script to swap /etc/fstab at boot based on the running kernel, but the device swap is not very user-friendly. Other than that, I've got no complaints - the system is running quite well!
--Eric Northup - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |