Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Mon, 21 Apr 2003 20:13:20 -0700 | From | Andrew Morton <> | Subject | Re: 2.5.68 oopses |
| |
Joseph Pingenot <trelane@digitasaru.net> wrote: > > I get the following when booting 2.5.68: > > Apr 21 00:41:37 paulus kernel: airo: Doing fast bap_reads > Apr 21 00:41:37 paulus kernel: airo: MAC enabled eth1 0:7:e:b8:d6:7d > Apr 21 00:41:37 paulus kernel: eth1: index 0x05: Vcc 5.0, Vpp 5.0, irq 4, io 0x0100-0x013f > Apr 21 00:41:37 paulus kernel: bad: scheduling while atomic!
It's not really an oops - but it's trying hard to become one.
Could you please run with this patch for a while, and let me know what it puts in the logs?
drivers/net/wireless/airo.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-)
diff -puN drivers/net/wireless/airo.c~airo-schedule-fix drivers/net/wireless/airo.c --- 25/drivers/net/wireless/airo.c~airo-schedule-fix 2003-04-21 20:09:39.000000000 -0700 +++ 25-akpm/drivers/net/wireless/airo.c 2003-04-21 20:11:43.000000000 -0700 @@ -44,6 +44,7 @@ #include <linux/ioport.h> #include <linux/config.h> #include <linux/pci.h> +#include <linux/delay.h> #include <asm/uaccess.h> #ifdef CONFIG_PCI @@ -2376,20 +2377,26 @@ static u16 setup_card(struct airo_info * static u16 issuecommand(struct airo_info *ai, Cmd *pCmd, Resp *pRsp) { // Im really paranoid about letting it run forever! int max_tries = 600000; + static int max = 0; + int count = 0; if (sendcommand(ai, pCmd) == (u16)ERROR) return ERROR; while (max_tries-- && (IN4500(ai, EVSTAT) & EV_CMD) == 0) { - if (!in_interrupt() && (max_tries & 255) == 0) - schedule(); + udelay(1); + count++; } - if ( max_tries == -1 ) { + if (max_tries == -1) { printk( KERN_ERR "airo: Max tries exceeded waiting for command\n" ); return ERROR; } completecommand(ai, pRsp); + if (count > max) { + max = count; + printk("%s: max delay = %d usec\n", __FUNCTION__, max); + } return SUCCESS; } _
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |