Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Mon, 21 Apr 2003 19:55:55 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] 2.5.68-bk1 crash in devfs_remove() for defpts files |
| |
On Mon, Apr 21, 2003 at 01:49:18PM -0400, Pavel Roskin wrote: > This patch > helps, but it probably shouldn't be applied unless it turns out to be > correct.
Right, the patch only hides the bug.
> By the way, I wonder why devfs_put(de) is called twice in a row in > devfs_remove().
Once for the temporary reference we got from _devfs_find_entry, the second time to actually make it go away.
Could you please try this patch?
--- 1.11/drivers/char/pty.c Mon Mar 31 03:16:19 2003 +++ edited/drivers/char/pty.c Mon Apr 21 18:32:46 2003 @@ -459,6 +459,7 @@ pts_driver[i].name_base = i*NR_PTYS; pts_driver[i].num = ptm_driver[i].num; pts_driver[i].other = &ptm_driver[i]; + ptm_driver[i].flags |= TTY_DRIVER_NO_DEVFS; pts_driver[i].table = pts_table[i]; pts_driver[i].termios = pts_termios[i]; pts_driver[i].termios_locked = pts_termios_locked[i]; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |