Messages in this thread | | | Date | Thu, 17 Apr 2003 13:57:19 +0100 | From | Christoph Hellwig <> | Subject | Re: [ANNOUNCE]: version 2.00.3 megaraid driver for 2.4.x and 2.5.67 kernels |
| |
On Thu, Apr 17, 2003 at 08:52:16AM -0400, Alan Cox wrote: > a) megaraid always used a set of basic typedefs. Seems to be your personal > view not general comment
At least Linus seems to share my opinion :)
> > Do you really need this? Why can you use > > struct device_driver->shutdown? > > Not on 2.2
This is a 2.5-only driver (in fact a 2.5 only patch against a 2.4 driver)
> > return FALSE; > > > > Please don't use TRUE/FALSE but 1/0 directly. > > TRUE/FALSE is IMHO perfectly clear
It's clear, but Linux kernel code avoids it usually. I'm currently getting rid of it in the scsi headers so it's a good idea to avoid it in new drivers.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |