Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 17 Apr 2003 13:16:09 -0700 | From | Andrew Morton <> | Subject | Re: softirq.c bug |
| |
farshad khoshkhui <farshad_kh@yahoo.com> wrote: > > I'm using 2.5.67, on a duron 1200 box , my keyboard lock up when a ppp > connection goes down and also > pppd process won't die and kill, and the box don't event shutdown!
I submitted the below (sad) patch yesterday:
This BUG_ON is triggering via ppp's line discipline flushing, due to brokenness in tty_io.c.
We need to fix tty. Meanwhile, let's not gratuitously nuke people's boxes.
25-akpm/kernel/softirq.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/softirq.c~local_bh_enable-niceness kernel/softirq.c --- 25/kernel/softirq.c~local_bh_enable-niceness Wed Apr 16 13:51:42 2003 +++ 25-akpm/kernel/softirq.c Wed Apr 16 13:51:47 2003 @@ -102,7 +102,7 @@ restart: void local_bh_enable(void) { __local_bh_enable(); - BUG_ON(irqs_disabled()); + WARN_ON(irqs_disabled()); if (unlikely(!in_interrupt() && local_softirq_pending())) invoke_softirq();
> I also found that my ethernet (rtl8139 NIC) don't work while CONFIG_ACPI=y > it's response to other stations arp requests but don't add others to arp table
Please log this in http://bugzilla.kernel.org
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |