Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Tue, 15 Apr 2003 19:40:36 -0700 | From | William Lee Irwin III <> | Subject | Re: 2.5.67-mm3 |
| |
On Tue, Apr 15, 2003 at 07:21:54PM -0700, William Lee Irwin III wrote: > follow_hugetlb_page() behaved improperly if its starting address was > not hugepage-aligned. It looked a bit unclean too, so I rewrote it. > This fixes a bug, and more importantly, makes the thing readable by > something other than a compiler (e.g. programmers).
And this one fixes an overflow when there is more than 4GB of hugetlb:
diff -urpN htlb-2.5.67-bk6-1/arch/i386/mm/hugetlbpage.c htlb-2.5.67-bk6-2/arch/i386/mm/hugetlbpage.c --- htlb-2.5.67-bk6-1/arch/i386/mm/hugetlbpage.c 2003-04-15 18:58:07.000000000 -0700 +++ htlb-2.5.67-bk6-2/arch/i386/mm/hugetlbpage.c 2003-04-15 19:25:30.000000000 -0700 @@ -482,9 +482,7 @@ int hugetlb_report_meminfo(char *buf) int is_hugepage_mem_enough(size_t size) { - if (size > (htlbpagemem << HPAGE_SHIFT)) - return 0; - return 1; + return (size + ~HPAGE_MASK)/HPAGE_SIZE <= htlbpagemem; } /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |