Messages in this thread | | | Date | Mon, 14 Apr 2003 09:15:08 -0700 | From | Mike Anderson <> | Subject | Re: [PATCH] 2.4.21-pre7 ide request races |
| |
Jens Axboe [axboe@suse.de] wrote: > On Mon, Apr 14 2003, Andrew Morton wrote: > > Jens Axboe <axboe@suse.de> wrote: > > > > > > How would that solve the problem? The request could be gone even before > > > end_that_request_last() is run, that is the issue. > > > > In that case I didn't understand your description of the bug even the tiniest > > little bit. > > > > That request is sitting in the kernel stack of some process which is sleeping > > in wait_for_completion(). Hence it is safe memory until someone runs > > complete() against the completion struct. > > Sorry you are right, that should fix the problem as well! Your fix is > probably the better one for 2.4, less intrusive. I'll kill the stack > requests in 2.5 then.
In 2.5 will you include the 2.4 end_that_request_last fix proposed in this thread along with removal of requests on the stack?
-andmike -- Michael Anderson andmike@us.ibm.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |