Messages in this thread | | | Subject | Re: [PATCH] small fixes in brlock.h | From | Robert Love <> | Date | 09 Mar 2003 19:15:25 -0500 |
| |
On Sun, 2003-03-09 at 18:44, Zwane Mwaikambo wrote:
> #define br_read_unlock_irqrestore(idx, flags) \ > - do { br_read_unlock(irx); local_irq_restore(flags); } while (0) > + do { br_read_unlock(idx); local_irq_restore(flags); } while (0)
BTW, I am amazed all these s/idx/irx/ bugs exist and no one noticed them.
I guess nothing uses these irq variants. In fact, grepping the source... wow, not much uses brlocks at all. Only registered lock is BR_NETPROTO_LOCK. A read lock on it is called only 7 times and a write lock is used 31 times.
Everything must of moved over to using RCU or something. It makes me question the future of these things.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |