Messages in this thread | | | Date | Tue, 4 Mar 2003 20:47:32 +0100 | From | Dominik Brodowski <> | Subject | Re: [PATCH] pcmcia: get initialization ordering right [Was: [PATCH 2.5] : i82365 & platform_bus_type] |
| |
On Tue, Mar 04, 2003 at 10:54:28AM -0800, Jean Tourrilhes wrote: > On Tue, Mar 04, 2003 at 11:48:22AM -0600, Patrick Mochel wrote: > > > > Surely you're sore that your code has required some modifications since > > Dominik has started working on PCMCIA, and I'm sure that no harm was > > intended. It's had some bumps, but IMO, he's done a great job, and the > > result is a vast improvement. The least you could is give the guy some > > slack, instead of whining about your own inconveniences. > > I don't mind the changes, changes are usually good. In 2.5.X, > I had to change my code to accomodate the new PCI interface, the > removal of global IRQ, the new module interface, the various USB API > changes and other changes. And actually, your work currently hasn't > had any impact on the source code I follow (yet). > What I mind is the lack of basic testing. From your patch, the > initialisation order mixup and the other obvious bug fix I sent you, > this code had zero chances of working at all and it's obvious that > nobody bothered to check if it could work or not for at least two > kernel releases.
The problem is that I only have one yenta-compatible cardbus controller, and one pcmcia card -- no real "infrastructure" to test the patches.[*] And I really try to verify that my patches work, but obviously I had a bad day when I wrote the "let's add a pcmcia socket devices class" patch. Nonetheless, one point you mention is perfectly valid -- the kernel is in a feature freeze.
Dominik
[*] Needless to say, the patches I sent tend to work on the hardware I own... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |