lkml.org 
[lkml]   [2003]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[2.5 patch] fix ipmi_devintf.c compilation
On Mon, Mar 24, 2003 at 03:26:47PM -0800, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.65 to v2.5.66
> ============================================
>...
> Christoph Hellwig <hch@sgi.com>:
>...
> o misc devfs_register cleanups
>...


This patch broke the compilation of drivers/char/ipmi/ipmi_devintf.c:

<-- snip -->

...
gcc -Wp,-MD,drivers/char/ipmi/.ipmi_devintf.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default
-nostdinc -iwithprefix include -DKBUILD_BASENAME=ipmi_devintf
-DKBUILD_MODNAME=ipmi_devintf -c -o drivers/char/ipmi/ipmi_devintf.o
drivers/char/ipmi/ipmi_devintf.c
drivers/char/ipmi/ipmi_devintf.c: In function `ipmi_new_smi':
drivers/char/ipmi/ipmi_devintf.c:452: warning: implicit declaration of
function `snprinf'
...
... -o .tmp_vmlinux1
...
drivers/built-in.o(.text+0x142824): In function `ipmi_new_smi':
: undefined reference to `snprinf'
...
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->


Trivial fix:


--- linux-2.5.66-notfull/drivers/char/ipmi/ipmi_devintf.c.old 2003-03-26 13:34:17.000000000 +0100
+++ linux-2.5.66-notfull/drivers/char/ipmi/ipmi_devintf.c 2003-03-26 13:34:34.000000000 +0100
@@ -449,7 +449,7 @@
if (if_num > MAX_DEVICES)
return;

- snprinf(name, sizeof(name), "ipmidev/%d", if_num);
+ snprintf(name, sizeof(name), "ipmidev/%d", if_num);

handles[if_num] = devfs_register(NULL, name, DEVFS_FL_NONE,
ipmi_major, if_num,


cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.097 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site