lkml.org 
[lkml]   [2003]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] Module load notification take 3
Date
In message <20030325114152.GB30581@compsoc.man.ac.uk> you write:
> On Tue, Mar 25, 2003 at 05:32:33PM +1100, Rusty Russell wrote:
>
> > > Implement a module load notifier for the benefit of OProfile, tested
> > > with .66 on UP.
> >
> > Minor change to make unregister_module_notifier return void.
>
> The -ENOENT return is there for a reason.

What reason? I just grepped 2.5.66-bk2, and *noone* uses the return
value, not even to BUG() (you have to grep for all the wrappers for
notifier_call_unregister, too).

That's because everyone realizes that the return value is useless.

> If you don't want it, then you should remove it from
> notifier_call_register too.

(I assume you mean notifier_call_unregister). Yes, but that's another
battle.

Meanwhile, at least I'm not adding to the problem.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.042 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site