Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 26 Mar 2003 16:08:10 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH] s390 update (4/9): common i/o layer update. |
| |
On Wed, Mar 26, 2003 at 04:10:16PM +0100, Martin Schwidefsky wrote: > + typeof (chsc_area_ssd.response_block) > + *ssd_res = &chsc_area_ssd.response_block;
Yikes! Please use the actual type here instead of typeof()
> + if (sch->lpm == 0) > + return -ENODEV; > + else > + return -EACCES;
I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm just too picky..
> - sch = kmalloc (sizeof (*sch), GFP_DMA); > + sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);
What about using GFP_KERNEL | __GFP_DMA instead? This makes it more clear that it's just a qualifier.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |