Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [BK FBDEV] A few more updates. | From | Benjamin Herrenschmidt <> | Date | 25 Mar 2003 19:35:54 +0100 |
| |
On Tue, 2003-03-25 at 19:28, Benjamin Herrenschmidt wrote:
> You "fixed" it by using GFP_ATOMIC but didn't test the result of > kmalloc. That is very bad. GFP_ATOMIC can fail (return NULL), thus > you will crash the kernel under high memory pressure. > > I think the proper fix is, as you asked me, using a workqueue, > that way, you can both use GFP_KERNEL allocations, and avoid > the spinlock you added to fbmem.c, thus letting the fb_sync() > ops on fbdev's be able to block.
Well, actually, creating a workqueue would be overhead since it involves one kernel thread per CPU. After more thinking & discussion, I beleive you shall rather use keventd existing workqueue (schedule_work() will do that)
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |