Messages in this thread | | | Date | Tue, 25 Mar 2003 02:04:19 +0000 | From | Dave Jones <> | Subject | Re: [PATCH] More i2c driver changes for 2.5.65 |
| |
On Mon, Mar 24, 2003 at 05:29:23PM -0800, Greg KH wrote:
> > > + .name = "ADM1021-MAX1617", > > Why dash here > > > + .name = "LM75 sensor", > > And space here? Also you should have > > either 2x "sensor" or none at all. > What do you mwan "2x"?
The way I parsed it, either have.. .name = "ADM1021-MAX1617 sensor", .name = "LM75 sensor",
or
.name = "ADM1021-MAX1617", .name = "LM75",
ie, both, or all. Personally the latter looks better to me. Especially given the 16 char limit. Aren't these going to be in a sysfs heirarchy where its obvious they are sensors anyway ? like i2c/sensors/lm75 ?
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |