Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [x86-64] Add missing tlb flush after change_page_attr | From | Andi Kleen <> | Date | 24 Mar 2003 18:32:16 +0100 |
| |
On Mon, 2003-03-24 at 17:41, davej@codemonkey.org.uk wrote: > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/x86_64/kernel/pci-gart.c linux-2.5/arch/x86_64/kernel/pci-gart.c > --- bk-linus/arch/x86_64/kernel/pci-gart.c 2003-03-08 09:56:51.000000000 +0000 > +++ linux-2.5/arch/x86_64/kernel/pci-gart.c 2003-03-18 21:19:53.000000000 +0000 > @@ -419,6 +419,7 @@ static __init int init_k8_gatt(agp_kern_ > panic("Cannot allocate GATT table"); > memset(gatt, 0, gatt_size); > change_page_attr(virt_to_page(gatt), gatt_size/PAGE_SIZE, PAGE_KERNEL_NOCACHE); > + global_flush_tlb(); > agp_gatt_table = gatt; > > for_all_nb(dev) {
No it needs to be completely removed. the pci aperture is supposed to be cachable (unlike the AGP aperture) That's still a trace of an earlier design.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |