Messages in this thread | | | Subject | Re: [PATCH] Fixup warning for acenic | From | Jes Sorensen <> | Date | 20 Mar 2003 10:47:49 -0500 |
| |
>>>>> "Martin" == Martin J Bligh <mbligh@aracnet.com> writes:
Martin> OK, it's war on warnings hour. Get this from acenic, Martin> drivers/net/acenic.c:135: warning: `acenic_pci_tbl' defined Martin> but not used
Martin> And indeed it doesn't *seem* to be used (though I'm less than Martin> confident about that) ... can we just rip it out? Or should Martin> this be wrapped in #ifdef MODULE or something (I'm compiling Martin> it in)?
Hi Martin,
The table isn't used at the moment, however at some point it should be. I have been reluctant to change the driver over to the new hotplug scheme since in the past there has been a significant number of AceNIC users running on older kernels which do not have the hotplug infrastructure (2.4.9 etc). On the other hand I don't remember hearing from a single person who wanted to use AceNIC in a hotplug environment.
Anyway most people seems to be at 2.4.18 or later these days so maybe it is time to retire the old code. I will try to find time to take a look at it (or if someone beats me to it and sends me a patch ... ;-)
Cheers, Jes
PS: There is an email address listed in the driver, please CC patches to it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |