Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Rusty Russell <> | Subject | Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c | Date | Mon, 10 Feb 2003 11:29:30 +1100 |
| |
In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write: > --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500 > +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500 > @@ -140,7 +140,7 @@ > { > int ret=-1; > > - if (MAX_GPIO_LINE > *data >= 0) > + if ((MAX_GPIO_LINE > *data) && (*data >= 0)) > ret=ite_gpio_irq_pending[*data]; > > DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
Nope, of course *data is >= 0, it's a u32.
Once again, the author needs to indicate (and test!) what was meant here...
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |