Messages in this thread | | | Date | Fri, 7 Feb 2003 22:58:17 +0100 | From | "J.A. Magallon" <> | Subject | Re: [PATCH] 2.5.59 : sound/oss/vidc.c |
| |
On 2003.02.07 Richard B. Johnson wrote: > On Fri, 7 Feb 2003, John Bradford wrote: > [...] > > for (new2size = 128; new2size < newsize; new2size <<= 1) > ; > > The code seems to want to make the value of new2size a power of > 2 and, greater than 128, but less than newsize. It ignores the > fact that newsize might be less than 128, maybe this is okay. > But, the code goes on, eventually settling on new2size being > less than 4096... hmmm. I'll bet this could be greatly > simplified. I think 'new2size' is really something that will > fit inside 128-byte groups. Maybe an & or a % will greatly > simplify? >
Isn't just a ffs or the like ?
-- J.A. Magallon <jamagallon@able.es> \ Software is like sex: werewolf.able.es \ It's better when it's free Mandrake Linux release 9.1 (Cooker) for i586 Linux 2.4.21-pre4-jam1 (gcc 3.2.1 (Mandrake Linux 9.1 3.2.1-5mdk)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |