Messages in this thread | | | Date | Thu, 6 Feb 2003 14:14:52 +0000 | From | Christoph Hellwig <> | Subject | Re: [patch] Update of the input subsystem - 37 csets |
| |
On Thu, Feb 06, 2003 at 03:10:25PM +0100, Vojtech Pavlik wrote: > On Thu, Feb 06, 2003 at 01:49:39PM +0000, Christoph Hellwig wrote: > > > * Some laptops take the 789uiojklm,. keys as number pad when NumLock is on. > > * This seems a good reason to start with NumLock off. > > */ > > +#ifndef CONFIG_X86_PC9800 > > #define KBD_DEFLEDS 0 > > +#else > > +#define KBD_DEFLEDS (1 << VC_NUMLOCK) > > +#endif > > #endif > > > > This ifdef is the wrong way around. > > The ifdef is the right way around. KBD_DEFLEDS used to be 0. Now > KBD_DEFLEDS is also 0, except when CONFIG_X86_PC9800 is defined. Note > it's an if*n*def there.
yes, that's what I meant :) Don't use ifndef nless nessecary. Sorry for the unclear wording.
> Hmm. I know this isn't the prefered way of doing it, but so far it's the > most convenient one - serio.h still changes now and then (adding new > #defines, etc), and the only one program using it is inputattach.c. To > me it seems quite sane to have inputattach.c include this kernel header. > If you know of any other reasonably maintainable way to do it ...
split serio.h into serio_ids.h (the ids used by inputattach.c) and serio.h (the actual kernel header). Copy over serio_ids.h to the inputattach source tarball and resync it whenever nessecary.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |