Messages in this thread Patch in this message | | | Subject | Re: 2.4.21-pre4: PDC ide driver problems with shared interrupts | From | Benjamin Herrenschmidt <> | Date | 07 Feb 2003 00:04:18 +0100 |
| |
On Thu, 2003-02-06 at 13:20, Stephan von Krawczynski wrote: > On 05 Feb 2003 18:12:31 +0100 > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > > > Stephan: Can you try editing ide-dma.c, function > > __ide_dma_test_irq(), and remove that line: > > > > - drive->waiting_for_dma++; > > > > And tell us if it helps in any way. > > > > Ben. > > Hello Ben, > > as requested I tried the above "patch" and had no problem so far. Current > situation is: > (ide2, ide3 are PDC, eth2 is tg3)
Ok, well, if it' still stable by now, I beleive we can safely remove that line from ide_dma_test_irq(). AFAIK, it really have nothing to do here.
(I suspect it got copied from ide-pmac somewhat... I use it as a counter in there to implement some timeout when the DMA engine didn't start at all because the disk issued an error, and on these, I know for sure the IRQ isn't shared...)
Alan, can you include that ?
===== drivers/ide/ide-dma.c 1.10 vs edited ===== --- 1.10/drivers/ide/ide-dma.c Sat Feb 1 20:37:36 2003 +++ edited/drivers/ide/ide-dma.c Fri Feb 7 00:03:43 2003 @@ -826,7 +826,6 @@ if (!drive->waiting_for_dma) printk(KERN_WARNING "%s: (%s) called while not waiting\n", drive->name, __FUNCTION__); - drive->waiting_for_dma++; return 0; }
(Patch against Marcelo's 2.4.21-pre4)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |