Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Fri, 28 Feb 2003 12:39:05 +0530 | From | Maneesh Soni <> | Subject | Re: kernel Ooops (2.5.63 bk latest) |
| |
Hi Linus,
The BUG was caught in d_validate() --> dget(). I think the dentry to be validated can be already on LRU list with d_count as zero. So, dget_locked should be used in place of dget(). dcache_rcu mistakingly used dget. This patch corrects it.
Please apply the following patch.
diff -urN linux-2.5.63-bk3/fs/dcache.c linux-2.5.63-bk3-d_validate/fs/dcache.c --- linux-2.5.63-bk3/fs/dcache.c 2003-02-28 12:06:09.000000000 +0530 +++ linux-2.5.63-bk3-d_validate/fs/dcache.c 2003-02-28 12:16:30.000000000 +0530 @@ -1056,7 +1056,7 @@ * as it is parsed under dcache_lock */ if (dentry == list_entry(lhp, struct dentry, d_hash)) { - dget(dentry); + __dget_locked(dentry); spin_unlock(&dcache_lock); return 1; }
Regards, Maneesh
-- Maneesh Soni IBM Linux Technology Center, IBM India Software Lab, Bangalore. Phone: +91-80-5044999 email: maneesh@in.ibm.com http://lse.sourceforge.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |