Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 20 Feb 2003 16:44:25 -0800 | From | Greg KH <> | Subject | [PATCH] PCI fixes for 2.5.62 |
| |
ChangeSet 1.1003, 2003/02/20 14:23:27-08:00, greg@kroah.com
[PATCH] PCI: remove large stack usage in pci_do_scan_bus()
diff -Nru a/drivers/pci/probe.c b/drivers/pci/probe.c --- a/drivers/pci/probe.c Thu Feb 20 16:46:35 2003 +++ b/drivers/pci/probe.c Thu Feb 20 16:46:35 2003 @@ -505,23 +505,30 @@ { unsigned int devfn, max, pass; struct list_head *ln; - struct pci_dev *dev, dev0; + struct pci_dev *dev; + + dev = kmalloc(sizeof(*dev), GFP_KERNEL); + if (!dev) { + printk(KERN_ERR "Out of memory in %s\n", __FUNCTION__); + return 0; + } DBG("Scanning bus %02x\n", bus->number); max = bus->secondary; /* Create a device template */ - memset(&dev0, 0, sizeof(dev0)); - dev0.bus = bus; - dev0.sysdata = bus->sysdata; - dev0.dev.parent = bus->dev; - dev0.dev.bus = &pci_bus_type; + memset(dev, 0, sizeof(*dev)); + dev->bus = bus; + dev->sysdata = bus->sysdata; + dev->dev.parent = bus->dev; + dev->dev.bus = &pci_bus_type; /* Go find them, Rover! */ for (devfn = 0; devfn < 0x100; devfn += 8) { - dev0.devfn = devfn; - pci_scan_slot(&dev0); + dev->devfn = devfn; + pci_scan_slot(dev); } + kfree(dev); /* * After performing arch-dependent fixup of the bus, look behind - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |