Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 19 Feb 2003 10:07:43 +0100 | From | Jan-Benedict Glaw <> | Subject | Re: [PATCH] morse code panics for 2.5.62 |
| |
On Tue, 2003-02-18 23:49:46 +0100, Tomas Szepe <szepe@pinerecords.com> wrote in message <20030218224946.GB1048@louise.pinerecords.com>: > > [jbglaw@lug-owl.de] > > > > Then, you can have > > const char morses[] = { > > MORSE2('A', '.', '-'), > > MORSE4('B', '-', '.', '.', '.'), > > MORSE4('C', '-', '.', '-', '.'), > > MORSE3('D', '-', '.', '.'), > > MORSE1('E', '.'), > > MORSE4('F', '.', '.', '-', '.') > > ... > > }; > > > > That's going to take exactly the same memory in the compiled vmlinux > > image, *and* it's really readable:-) Of course, gcc will optimize any > > added "bloat" away... > > Looks good to me, can you send an updated patch?
Okay, I'll first have to import your original patch:-) and have a real look at it (how does it exactly store the data...). Then, I'll do an undated patch. Please give me an hour ot two...
MfG, JBG
-- Jan-Benedict Glaw jbglaw@lug-owl.de . +49-172-7608481 "Eine Freie Meinung in einem Freien Kopf | Gegen Zensur fuer einen Freien Staat voll Freier Bürger" | im Internet! Shell Script APT-Proxy: http://lug-owl.de/~jbglaw/software/ap2/ [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |