Messages in this thread | | | Subject | Re: PATCH: clean up the IDE iops, add ones for a dead iface | From | Alan Cox <> | Date | 19 Feb 2003 01:53:04 +0000 |
| |
On Tue, 2003-02-18 at 23:09, Russell King wrote: > On Tue, Feb 18, 2003 at 06:03:21PM +0000, Alan Cox wrote: > > +static u8 ide_unplugged_inb (unsigned long port) > > +{ > > + return 0xFF; > > +} > > Shouldn't this return 0x7f, ie bit 7 clear, as if we have an interface > without drive attached?
0xFF is what most hardware returns for an unclaimed pci address. I'd rather make sure it also works when we don't get the event, or the device summarily explodes than fake up something to make it look good. If 0xff doesnt work we have a bug anyway, lets find them.
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |