lkml.org 
[lkml]   [2003]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.5] IRQ distribution patch for 2.5.58
On Thu, Jan 16, 2003 at 01:08:55PM -0800, Kamble, Nitin A wrote:
> + spin_lock(&desc->lock);
> + irq_balance_mask[selected_irq] = target_cpu_mask;
> + spin_unlock(&desc->lock);

Wrong.

irq_balance_mask[selected_irq] = cpu_to_logical_apicid(min_loaded);

... except this needs auditing for the assumption that the RTE's are
using logical DESTMOD.

Guess whose box won't boot with your code in?

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.041 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site