Messages in this thread | | | Date | Mon, 17 Feb 2003 09:03:39 -0800 | From | Bob Miller <> | Subject | Re: [PATCH 2.5.60 5/9] Update the Archimedes parallel port driver for new module API. |
| |
On Mon, Feb 17, 2003 at 01:54:59PM +1100, Rusty Russell wrote: > In message <20030215100424.A20365@flint.arm.linux.org.uk> you write: > > On Fri, Feb 14, 2003 at 04:37:00PM -0800, Bob Miller wrote: > > > -static void arc_inc_use_count(void) > > > +static int arc_inc_use_count(void) > > > { > > > -#ifdef MODULE > > > - MOD_INC_USE_COUNT; > > > -#endif > > > + return try_module_get(THIS_MODULE); > > > } > > > > Isn't one of the points of the module system that we don't try to run > > code inside a module without the module being reference counted? > > Exactly. You can do it if you *know* you already hold a reference > count, but as a general rule it's damn suspicious. > > This looks wrong, > Rusty.
Thanks for the feed back. I'll fix this and re-submit.
-- Bob Miller Email: rem@osdl.org Open Source Development Lab Phone: 503.626.2455 Ext. 17 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |