Messages in this thread | | | Date | Fri, 14 Feb 2003 17:32:17 +0300 | From | Ivan Kokshaysky <> | Subject | Re: [PATCH] EISA/sysfs update |
| |
On Fri, Feb 14, 2003 at 11:16:24AM +0100, Marc Zyngier wrote: > # - Add driver for i82375 PCI/EISA bridge.
I believe this driver will work for any PCI/EISA bridge without any changes, not only for i82375. Probably we need to look for a class code rather than a device id.
Also, to get rid of that x86-ism I'd suggest something like
i82375_root.dev = &pdev->dev; i82375_root.dev->driver_data = &i82375_root; - i82375_root.bus_base_addr = 0; /* Warning, this is a x86-ism */ - i82375_root.res = &ioport_resource; + i82375_root.res = pdev->bus->resource[0]; + i82375_root.bus_base_addr = pdev->bus->resource[0]->start; i82375_root.slots = EISA_MAX_SLOTS;
Without that you'll have resource conflicts on multi-hose alphas.
Otherwise, the patch looks good to me.
Ivan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |