lkml.org 
[lkml]   [2003]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.6.0-test11] VFAT fix for UTF-8 and trailing dots
From
Date
Michal Rokos <m.rokos@sh.cvut.cz> writes:

> I don't know... Functions in nls_base.c have specification the same as
> those from userspace (defined by ISO/ANSI C or UNIX98).
>
> Probably we should. This was meant as minimal patch.
>
> In case you'll be modifiing nls_base.c, please, decide whether this
> shouldn't be in...
>
>
> --- linux-2.6.0-test11/fs/nls/nls_base.c.old 2003-11-26 21:44:31.000000000 +0100
> +++ linux-2.6.0-test11/fs/nls/nls_base.c 2003-12-06 20:09:01.000000000 +0100
> @@ -99,6 +99,7 @@ utf8_mbstowcs(wchar_t *pwcs, const __u8
> }
> } else {
> *op++ = *ip++;
> + n--;
> }
> }
> return (op - pwcs);
> >
> > For example, utf8_mbstowcs(outbuf, outlen, inbuf, inlen);
> >
>
> I'd would propose uft8_mbsntowcs(outbuf, outlen, inbuf, inlen);

Whoops, sorry. You are right.

But I really like the interface like iconv() than this. And current
nls interfaces also...

Anyway, I think your patches fix some bugs right now.
I'll submit the your both patches.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.026 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site