Messages in this thread | | | Date | Wed, 31 Dec 2003 20:03:22 -0700 | From | Grant Grundler <> | Subject | Re: [PATCH] pci_set_dac helper |
| |
On Wed, Dec 31, 2003 at 02:05:31PM -0500, Jeff Garzik wrote: > Matthew Wilcox wrote: > > I note that both this and your patch will lead to two errors being > > printed on 64-bit consistent failure; one by tg3 and one by the PCI > > layer; this seems suboptimal. I suspect you want to do away with the > > error printk in the tg3 driver. > > That was intentional in my patch, as it's a warning not an error in my > pci_set_dac. In your version I would agree.
It's perfectly ok for some platforms to not support 64-bit DMA mask for either type of DMA. The warning suggests it's not OK. I don't see why we either a warning or error printed unless it would lead to incorrect operation of the device.
grant - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |