lkml.org 
[lkml]   [2003]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Problem with dev_kfree_skb_any() in 2.6.0
David S. Miller wrote:
> On Tue, 30 Dec 2003 00:15:19 -0500
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>
>>OK, agreed. But fixing it in the driver is still incorrect, also.
>>
>>We need a single solution in the net stack, not a per-driver solution.
>
>
> I totally disagree.
>
> Let's quickly review, this is illegal:


You're missing the point.

Think about the name of this function: dev_kfree_skb_any()

If this function cannot be used -anywhere-, then the concept (and the
net stack) is fundamentally broken for this function. We must _remove_
the function, and thus _I_ have a lot of driver work to do.

[jgarzik@sata linux-2.5]$ find . -name '*.[ch]' -type f | grep -v SCCS |
xargs grep -wl dev_kfree_skb_any | wc -l
71

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.027 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site