Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 24 Dec 2003 23:12:18 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] fix make kernel rpm bug |
| |
On Thu, Dec 25, 2003 at 10:43:52AM +0800, Zhu, Yi wrote: > Hi Andrew, > > Below two lines patch makes the rpm rule in top Makefile be aware of > $(ARCH). The old rule will make wrong rpm if ARCH is not the same as > the build machine. > > > diff -Nru a/Makefile b/Makefile > --- a/Makefile Wed Dec 10 13:47:52 2003 > +++ b/Makefile Wed Dec 10 13:47:52 2003 > @@ -872,7 +872,7 @@ > $(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version;\ > mv -f $(objtree)/.tmp_version $(objtree)/.version; > > - $(RPM) -ta ../$(KERNELPATH).tar.gz > + $(RPM) --target $(ARCH) -ta ../$(KERNELPATH).tar.gz > rm ../$(KERNELPATH).tar.gz > > # Brief documentation of the typical targets used > diff -Nru a/scripts/mkspec b/scripts/mkspec > --- a/scripts/mkspec Wed Dec 10 13:47:52 2003 > +++ b/scripts/mkspec Wed Dec 10 13:47:52 2003 > @@ -9,7 +9,7 @@ > # Patched for non-x86 by Opencon (L) 2002 <opencon@rio.skydome.net> > # > # That's the voodoo to see if it's a x86. > -ISX86=`arch | grep -ie i.86` > +ISX86=`echo ${ARCH:=\`arch\`} | grep -ie i.86`
hmmm, I don't think $(ARCH) makes the rpm --target strings in all cases..
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |