Messages in this thread | | | Subject | Re: [PATCH 2/2][RFC] Add dm-crypt target | From | Christophe Saout <> | Date | Tue, 23 Dec 2003 14:36:22 +0100 |
| |
Am Di, den 23.12.2003 schrieb Christoph Hellwig um 14:13:
> Please include driver-private headers after kernel headers. > > > +struct crypt_c { > > crypt_context? The current name isn't very descriptive.. > > > +static kmem_cache_t *_io_cache; > > Again a rather strange variable name. What about dm_crypt_pool? > > Please kill these superflous wrappers. > > > +static spinlock_t _kcryptd_lock = SPIN_LOCK_UNLOCKED; > > +static struct bio *_bio_head; > > +static struct bio *_bio_tail; > > + > > +static struct dm_daemon _kcryptd; > > Again, rather strange naming..
This was done to be consistent with the other device-mapper code. I can change it though.
Joe?
-- Christophe Saout <christophe@saout.de> Please avoid sending me Word or PowerPoint attachments. See http://www.fsf.org/philosophy/no-word-attachments.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |