Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 17 Dec 2003 00:39:09 +0200 | From | Vladimir Kondratiev <> | Subject | Re: PCI Express support for 2.4 kernel |
| |
Arjan van de Ven wrote:
>>>+ /* dummy read to flush PCI write */ >>>+ readb(addr); >>> >>> >>This is going to choke some hardware, I guarantee. >> >>You always want to make sure your flush is of the same size at the >>write. Reading a byte from an address that the hardware defines as >>"32-bit writes only" can get ugly real quick ;-) >> >> > >also reading back addr might not be the best choice in case some >registers have side effects on reading, it's probably better to read >back an address that is known to be ok to read (like the vendor ID >field) > > > Good idea! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |