Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Dec 2003 04:48:27 +0000 | From | viro@parcelfa ... | Subject | Re: Is Rational rational? |
| |
On Mon, Dec 15, 2003 at 09:59:58PM -0500, Thomas Molina wrote: > static inline int may_delete(struct inode *dir,struct dentry *victim, int isdir) > { > int error; > - if (!victim->d_inode || victim->d_parent->d_inode != dir) > + if (!victim->d_inode) > return -ENOENT;
+ BUG_ON(victim->d_parent->d_inode != dir);
HAND.
> I'm not really competent to evaluate this proposesd patch, but it > certainly makes me nervous. Their comment on this also bothers me: > "Rational Software believes that the check that is removed by this patch > is one that should never fail for any properly operating filesystem. "
Precisely. It does fail for their code, though. Obvious conclusions are left as an exercise to readers. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |